perf: reuse aria attributes between all components#5160
Merged
Conversation
Now we have universally generated list of aria attributes and can reuse it instead of generating for every component and bloating our client bundle. Now users will have to download ~700kB less javascript when load builder. ```diff - 5748 build/client/assets + 5036 build/client/assets/ ```
TrySound
changed the title
kof
reviewed
Apr 24, 2025
kof
approved these changes
Apr 24, 2025
Member
kof
left a comment
kof
left a comment
There was a problem hiding this comment.
I don't understand why separating specifically aria attributes and not all common/universal html attributes
Contributor
Author
|
Because aria attributes has own rules based on roles. Regular attributes are based on tags. We are not doing it right at the moment though will improve in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #3632
We have a universally generated list of aria attributes and can reuse it instead of generating for every component and bloating our client bundle.
Now users will have to download ~700kB less javascript when load builder.